You are viewing a single thread.
View all comments 1 point
2
was good, thanks. 4
needs a tad more thought imho, returning an impl T
does have its place, because it makes changing the return type of the function a non-breaking change.
0 points
Number 4 is only about not returning impl Into
and instead just returning T
.
0 points
Hmm, right. I think it still might be warranted in niche cases, but trying to think of such a case made it pretty protracted in my head… maybe when functions can also be called for side effects, and the into
conversion is costly and the caller might not care about the return value?